fix: validate department based on company in expense claim #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkat102
force-pushed
the
validate_department
branch
from
d224f77 to
6880dfc
Compare
ruchamahabal
reviewed
Jan 8, 2025
| @@ -83,6 +88,14 @@ def set_status(self, update=False): | |||
| else: | |||
| self.status = status | |||
|
|
|||
| def validate_company_and_department(self): | |||
| if self.department: | |||
| if self.company != frappe.db.get_value("Department", self.department, "company"): | |||
There was a problem hiding this comment.
Nesting not needed here? Can combine with line number 92 using "and"
There was a problem hiding this comment.
Nesting not needed here? Can combine with line number 92 using "and"
yes
venkat102
force-pushed
the
validate_department
branch
from
d5826f7 to
5d3e23b
Compare
|
Can you fix tests related to this validation too? |
yes working on it |
venkat102
force-pushed
the
validate_department
branch
from
5d3e23b to
a4e8952
Compare
i-am-vimal
force-pushed
the
validate_department
branch
from
51a1bab to
e86ef6d
Compare
ruchamahabal
approved these changes
Jan 13, 2025
ruchamahabal
added a commit
that referenced
this pull request
Jan 13, 2025
…2582 fix: validate department based on company in expense claim (backport #2582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
allowing to submit expense claim with different departments with different companies
ref: 28450
Solution:
added filter for department field and validation for department based on company
Before:
before.webm
After:
after.webm
Backport needed for v15